Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDGA-22581] : CLI changes for Connection Pooling #240

Merged
merged 7 commits into from
Aug 29, 2024
Merged

[CLOUDGA-22581] : CLI changes for Connection Pooling #240

merged 7 commits into from
Aug 29, 2024

Conversation

adityakaushik99-yb
Copy link
Contributor

@adityakaushik99-yb adityakaushik99-yb commented Aug 23, 2024 •
edited
Loading

  • Changes for Connection Pooling
  • Tested on a cluster on devcloud. Works as expected

@adityakaushik99-yb adityakaushik99-yb requested a review from a team as a code owner August 23, 2024 04:59
@adityakaushik99-yb adityakaushik99-yb marked this pull request as draft August 23, 2024 04:59
@adityakaushik99-yb adityakaushik99-yb marked this pull request as ready for review August 26, 2024 09:03
harshitha-yb
harshitha-yb requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@harshitha-yb harshitha-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UTs

cmd/cluster/cluster.go Outdated Show resolved Hide resolved
cmd/cluster/connection-pooling/connection_pooling.go Outdated Show resolved Hide resolved
docs/ybm_cluster_connection-pooling.md Outdated Show resolved Hide resolved
@adityakaushik99-yb adityakaushik99-yb merged commit aabbf76 into main Aug 29, 2024
2 checks passed
@adityakaushik99-yb adityakaushik99-yb deleted the CLOUDGA-22581 branch August 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arishta-yb arishta-yb arishta-yb approved these changes

@harshitha-yb harshitha-yb harshitha-yb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityakaushik99-yb @arishta-yb @harshitha-yb